Conversation
Signed-off-by: Ari <nanoticity@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unsupported FetchContent_Declare argument in the top-level CMake configuration to fix configuration/build failures on CMake versions that don’t recognize DOWNLOAD_EXTRACT_TIMESTAMP.
Changes:
- Remove
DOWNLOAD_EXTRACT_TIMESTAMP TRUEfrom thegoogletestFetchContent_Declarecall.
Comment on lines
46
to
50
| include(FetchContent) | ||
| FetchContent_Declare( | ||
| googletest | ||
| URL https://github.com/google/googletest/archive/03597a01ee50ed33e9dfd640b249b4be3799d395.zip | ||
| DOWNLOAD_EXTRACT_TIMESTAMP TRUE | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charlie pls dont push stuff that doesnt work